Atif Iqbal• 3,200
@atif-dev
Posted
Hi Jyoti, congrats🎉 on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
(why main matters? Read here)
-
Later on when you are enough comfortable with CSS also learn responsive units/relative units. For further info watch this video
-
When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
Hope you will find this Feedback Helpful.
Marked as helpful
0
Jyoti Bhandari• 210
@Jyoti-Bhandari
Posted
@atif-dev thanks for the feedback. I will try my best to implement these points in future.
1
