Submitted 19 days ago

QR code component

Giselle L• 30

@Blangis

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud of make this challenge very similar to the design, I must use less div's

What challenges did you encounter, and how did you overcome them?

I had problems to fit the image in the correct way, I searched documentation online to learn about the correct settup

What specific areas of your project would you like help with?

The correct use of the "div" to contain information, at the begginning I thought to use a div for the image, and another for the text but the adjust of elements was difficult

Community feedback

rawatdinesh10• 30

@rawatdinesh10

Posted 18 days ago

You should not use display: flex property on child elements like you have used for the 'card' in your HTML code. Separate each child element in a containing <div> element. There is no id used in HTML code but you have used CSS style on id 'code_qr', please use id in HTML code and then style it accordingly, also there is an empty <div> in HTML code which should be removed.

Giselle L• 30

@Blangis

Posted 18 days ago

Hi @rawatdinesh10, I appreciate your feedback and would like to understand it better. Could you please clarify why you suggest avoiding display: flex on child elements?, or why should be better to use more div elements? Additionally, I noticed you mentioned that I didn't use the id in the HTML, but I did include it under the name code_qr as in the CSS. Regards

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord