QR first project on FrontEnd Mentor

Community feedback

• 

  👾 Ekaterine Mitagvaria 👾•7,600

  @catherineisonlinePosted almost 2 years ago

  HI! Your solution looks nice though there are a couple of things you can improve which I hope will be helpful! 😊

  The image with the class "image" should have an alt tag. Alt attribute for the image is important in order to specify alternative text for the image in case it will not be displayed. Using alt attribute is good for not only accessibility but also SEO and for situations when the image is loading too slowly. 
If the image is just for decoration you can still write an alt attribute but leave it empty, such images don’t need any alt tag but you will need to also add aria-hidden=“true”. What aria-hidden does is that it removes the entire element from the accessibility tree.

  If otherwise, you need to use an alt tag to describe the image. To write an alt tag you need to describe the content and purpose of the image and try not to use words like “picture of” or “image of”.

  Make sure to use rem (relative length value) or em units instead of pixels for the purpose of “respecting the user preferences”, to say so. It makes the “sizes” of the website fluid according to the zoom/sizes set by the user. I see you do use it but sometimes you use px, sometimes em, and sometimes rem.

  You can read more about it here: https://www.freecodecamp.org/news/what-is-rem-in-css/

  Also, your footer is inside the main tag. footer and headers should be separated from the main tag because they have completely different purposes.

  Marked as helpful

  0

  ---

  

  Felipe Salazar•140

  @andressalazar08Posted almost 2 years ago

  Hi @catherineisonline , thank you for the feedback and your time. I'm going to check how to improve my solution. Have a nice day!.

  0