Community feedback

• 

  P

  Jan•170

  @NegligencePosted 8 months ago

  Yogesh Peer Review

  I think you just initialized your project so I won't be too harsh. Here's a few things I've noticed:

  Structure-wise

  You might want to move the closing </div> from line :23 to line :18 instead. This will separate your .container from your .attribution.

    <div class="container">
    <img src="./images/image-qr-code.png" alt="">
    <h1>Improve your front-end skills by building projects</h1>
    <p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
    
    <div class="attribution">
    Challenge by : <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a> 
    Coded by : <a href="https://yogesh-Nagar.app">Yogesh Nagar</a>
    </div>
    </div>
  

  Font-wise

  You might want to connect a "Outfit" from Google Fonts

  Alternatively

  You can instead just copy and paste this code snippet at line :10 in your html

  <link rel="preconnect" href="https://fonts.googleapis.com">
  <link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
  <link href="https://fonts.googleapis.com/css2?family=Outfit:wght@100..900&display=swap" rel="stylesheet">
  

  0