Jason Ritter• 40
@Higokian
Posted
Great work! I'm only noticing two things you could take a look at.
Size
Like previously mentioned, reducing the size of the card would be good to better match the intended use case.
Semantic HTML
Instead of using a bunch of divs, you could change the qr-code-box div a <main></main> element and the attribution div could be a <footer></footer>.
Over-all, this is a great solution. Your code is clean and very well structured and you managed to get spacing within the box to appear spot on!
Here is a great resource for learning semantic HTML if you're unfamiliar with it: W3Schools Semantic Elements
0
