Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

P

@GGSWEngineer

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone!

Always love going back to build simple things to solidify fundamentals.

No specific questions, but feedback is always welcomed!

Community feedback

@AmrAbdelgwaad

Posted

Hey Gerardo, Congratulations on completing this challenge 🎉

your solution looks fantastic in the design comparison but there are a few things to take care of :

  • 100vw on the body is redundant to center that card with less code remove the width and height on body and main and set the min-height to 100vh on main to make your code look like this:
main {
 min-height: 100vh;
 display: flex;
 justify-content: center;
 align-items: center;
}
  • color: var(--Grey, #7d889e); you are using custom properties wrong know more about how to use it here
  • it will be beneficial if you use a modern CSS reset like this one

I hope I am helpful keep it up 😁

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord