QR Code Component

Community feedback

• 

  Amr mohamed•370

  @AmrAbdelgwaadPosted about 1 year ago

  Hey Gerardo, Congratulations on completing this challenge 🎉

  your solution looks fantastic in the design comparison but there are a few things to take care of :

  • 100vw on the body is redundant to center that card with less code remove the width and height on body and main and set the min-height to 100vh on main to make your code look like this:

  main {
   min-height: 100vh;
   display: flex;
   justify-content: center;
   align-items: center;
  }
  

  • color: var(--Grey, #7d889e); you are using custom properties wrong know more about how to use it here
  • it will be beneficial if you use a modern CSS reset like this one

  I hope I am helpful keep it up 😁

  0