Qr Code Component

Community feedback

• 

  Adeola Ganiu•1,320

  @DeolabestPosted about 2 years ago

  Hey @AliMahmoud21, Congratulations on completing this challenge!

  Here is my feedback:

  • It's not a good practice to use px to set font-size. Instead use rem units, they are great since they adapt better to the font-size the user will set in the browser settings. You can convert from px to rem here: https://pixelsconverter.com/px-to-rem.

  • Use <main> instead of a simple <div> to improve the semantics and accessibility on the page. Remember that every page should have a <main> block and that <div> doesn't have any semantic meaning.

  • Align the text to the center of the container. Solution: align-items: center;

  Keep doing a good job!

  Marked as helpful

  1

  ---

  

  Ali Mahmoud•390

  @AliMahmoud21Posted about 2 years ago

  @Deolabest i'll check rem and learn it also start using it in my designs, i noticed it has been using a lot in every desing i've seen the past few weeks.

  • thanks for your feedback, it was really helpful....

  0