QR Code Component

Community feedback

• 

  P

  LJBL•370

  @LJBL22Posted almost 2 years ago

  Hi Boots,

  Congrats and WELL DONE for your first challenge!

  I am also new here, and drop by to your solution. Here are my advice, if you don't mind.

  HTML

  • I was told when I started coding that coding style is important. For example, I notice that you know wrapping <h1> and <p> inside a <div>, good! And it could be easier for people to read if you use indent before those two child elements, let others know the relationship (parent & child) bt these tags. Try to improve every time when you code, and surely people will enjoy to read and work with you in the first place ^^.

  CSS

  • I noticed that your main card height is little shorter than the design. After checking, I think you could probably consider give a height for the <main>, or consider use padding on your text. For me, I personally use padding in this case instead of margin because it save me some math and thoughts about how they cover each other. But, it's just my opinions, those pixels are tricky, so ~ hope above is useful to you!

  Here is mine if you're interested. Happy coding ^^

  1

  ---

  

  Boots 😺•1,590

  @adityaphasuPosted almost 2 years ago

  @LJBL22 thanks for the feedback! I'll make sure to improve the code :D

  -> About the CSS I was wondering that too! I'd probably give the text div some padding rather than setting a height to the main tag

  0

  

  P

  LJBL•370

  @LJBL22Posted almost 2 years ago

  @adityaphasu No problem, happy to discuss with you ^^

  0