Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

Boots 😺• 1,590

@adityaphasu

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I'm new here! Any Feedback is welcome :)

Community feedback

P
LJBL• 200

@LJBL22

Posted

Hi Boots,

Congrats and WELL DONE for your first challenge!

I am also new here, and drop by to your solution. Here are my advice, if you don't mind.

HTML

  • I was told when I started coding that coding style is important. For example, I notice that you know wrapping <h1> and <p> inside a <div>, good! And it could be easier for people to read if you use indent before those two child elements, let others know the relationship (parent & child) bt these tags. Try to improve every time when you code, and surely people will enjoy to read and work with you in the first place ^^.

CSS

  • I noticed that your main card height is little shorter than the design. After checking, I think you could probably consider give a height for the <main>, or consider use padding on your text. For me, I personally use padding in this case instead of margin because it save me some math and thoughts about how they cover each other. But, it's just my opinions, those pixels are tricky, so ~ hope above is useful to you!

Here is mine if you're interested. Happy coding ^^

1

Boots 😺• 1,590

@adityaphasu

Posted

@LJBL22 thanks for the feedback! I'll make sure to improve the code :D

-> About the CSS I was wondering that too! I'd probably give the text div some padding rather than setting a height to the main tag

0
P
LJBL• 200

@LJBL22

Posted

@adityaphasu No problem, happy to discuss with you ^^

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord