Qr Code Component

Community feedback

• 

  Kawsar Ahmed Fahad•2,660

  @faha1999Posted about 2 years ago

  Hello, RobicaCodeaza Congratulations on finishing this project. It's lovely and great on the whole! Just a little tip:

  • You might want to use semantic tags like the <main> to wrap your code, instead of div. like

  <main class="container">
        <div class="qr-preview"></div>
  </main>
  

  You could also make use of <section> and/or <article> semantic tags. This would help improve accessibility.

  • add justify-content: center; to the body, it will center everything.

  • remove margin: 0 auto; from .container. it is not necessary anymore.

  • I saw in the style.css that sometimes you use px & rem. To optimize your speed when resizing fonts for various displays and devices, substitute rem or em rather than px. These components work better to improve the accessibility of your website. REM applies to all sizes, not just the font size.

  I hope it will work. Happy coding.

  Marked as helpful

  1

  ---

  

  RobicaCodeaza-AsForGithub•180

  @RobicaCodeazaPosted about 2 years ago

  @faha1999 Thank you for your time.Just to make sure i understood the part that was about rem|em|px.Were you suggesting that i should use rem/em across entire style.css?...:)

  0
• 

  Lucas 👾•104,400

  @correlucasPosted about 2 years ago

  👾Hi @RobicaCodeaza, congratulations on your first solution!👋 Welcome to the Frontend Mentor Coding Community!

  Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

  1.Replace the <h3> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

  2.Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

  3.Something that can be a time saver for you is to use a CSS RESET to remove all default settings for margins, making the images easier to work, see the article below where you can copy and paste this CSS code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

  ✌️ I hope this helps you and happy coding!

  Marked as helpful

  0