QR code component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  Replace the first <p> with h1 to fix the accessibility issues.

  To center the main on the page using flexbox, replace the height in the body with min-height:100vh.

  Add a padding value of all the sides and a font-size of 15px to the section.

  Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  0
• 

  Felipe Salazar•140

  @andressalazar08Posted almost 2 years ago

  @EAgard-34

  Hello Eric,

  First of all, I congratulate you on the delivery. I share some observations about the project.

  1.Check the image path as it is not rendering on deploy.

  2.Try to customize the README with your project description and the corresponding release links.

  3.Review the use of the color definition in root. These can be accessed later with var in your style sheet. I share a link about it:link_to_root_in_css

  4.the font size property and some length units are recommended to be defined in relative way using rem. That is for responsive and accessibility aspects in browsers. Check the following link on the subject: link to rem units.

  I think that for now is what I can recommend. Happy coding!!

  best regards,

  Felipe

  0