QR code component

Community feedback

• 

  Alamin•2,000

  @CodeWithAlaminPosted almost 2 years ago

  This comment was deleted almost 2 years ago

  1

  ---

  

  Daniel•100

  @dnoracPosted almost 2 years ago

  @CodePapa360 Thank you for your feedback.

  After careful consideration for each suggestion, this is what I have decided:

  Margins

  Reseting the margin on the body element does not automatically reset the margins for elements nested in the body element. The user agent stylesheet defines margins for a wide variety of elements, and they don't inherit from the body element unless explicitly defined, either by declaring margin: inherit; on each selector or by doing so in a universal selector.

  Box sizing

  This suggestion is gladly accepted and will be applied to my next challenges. Since it hasn't compromised the execution of current challenge, I decided not to update it for the time being.

  box-shadow property

  The reports from Can I use... suggest that adding vendor prefixes for box-shadow increases global browser support by a feeble 0.09% (from 97.86% to 97.95%). Besides, the lack of support for this property wouldn't meaningfully impact the user experience; the browser would effectively ignore it. Hence, while this suggestion is appreciated, I find it provides little benefit compared to the effort of adding Autoprefixer to the development toolchain.

  You are welcome to provide feedback on other challenge executions of mine

  Attentively, Daniel

  0