Skip to content
Submitted almost 2 years ago

QR Code Component

Ziane Maamar•40
@drxdesign
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I didn't want to use any CSS but I've been forced to use style in the HTML because I wanted to make one page HTML while using only CDN only but overall, I think the result is Good if you have any critics, please let me know

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted almost 2 years ago

    Hello there 👋. Congratulations on completing your first challenge! You have done a great job and I can see you are on the right track.

    I have some suggestions about your code that might interest you.

    HTML 📄:

    • Figure elements (<figure>) should only be used when captions are required with <figcaption>, you can directly use the image tag in this solution.
    • Use the <main> tag to wrap all the main content of the page instead of the <figure> tag. With this semantic element you can improve the accessibility of your page.
    • Use the <footer> tag to wrap the footer of the page instead of the <div class="attribution">. The <footer> element contains information about the author of the page, the copyright, and other legal information.

    Alt text 📷:

    • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

      If you want to learn more about the alt attribute, you can read this article. 📘.

    CSS 🎨:

    • To center the card you can use the grid layout:
    <body class="grid min-h-screen place-items-center">
    . . . 
</body>

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    1
    Ziane Maamar•40
    @drxdesignPosted almost 2 years ago

    @MelvinAguilar Thank you for the feedback I really appreciate it I'll fix things you showed me, and I'll add maybe dark mode use tailwind CSS dark mode again thank you

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord