@MelvinAguilar
Posted
Hello there 👋. Congratulations on completing your first challenge! You have done a great job and I can see you are on the right track.
I have some suggestions about your code that might interest you.
HTML 📄:
- Figure elements (
<figure>) should only be used when captions are required with<figcaption>, you can directly use the image tag in this solution.
- Use the
<main>tag to wrap all the main content of the page instead of the<figure>tag. With this semantic element you can improve the accessibility of your page.
- Use the
<footer>tag to wrap the footer of the page instead of the<div class="attribution">. The<footer>element contains information about the author of the page, the copyright, and other legal information.
Alt text 📷:
-
The
altattribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a betteraltattribute would beQR code to frontendmentor.ioIf you want to learn more about the
altattribute, you can read this article. 📘.
CSS 🎨:
- To center the card you can use the grid layout:
<body class="grid min-h-screen place-items-center">
. . .
</body>
I hope you find it useful! 😄 Above all, the solution you submitted is great!
Happy coding!
@drxdesign
Posted
@MelvinAguilar Thank you for the feedback I really appreciate it I'll fix things you showed me, and I'll add maybe dark mode use tailwind CSS dark mode again thank you
