QR code component

Community feedback

• 

  Marcos Travaglini•4,840

  @BlackpachamamePosted 11 months ago

  Good job!

  Here are some comments that may help you:

  • Use min-height: 100vh instead of height; 100vh (with this you are restricting a specific height, it can generate unexpected results)
  • Use semantic tags such as main, footer, figure, etc, this helps the accessibility and SEO of the site
  • The <div class="card"> should be <main class="card">
  • Applying the margin on only screen and (min-width: 500px) is no longer necessary
  • Apply display: block to the image to remove that annoying white space

  Marked as helpful

  1

  ---

  

  kevinyuri•170

  @kevinyuriPosted 11 months ago

  @Blackpachamame Thanks for checking my code and giving your feedback!

  0