Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Blerim 270

@approved4me

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Much easier than the previous one, although in the order later, when sorting from Easy to Hard.

Community feedback

@VCarames

Posted

Hey there! 👋 Here are some suggestions to help improve your code:

  • The alt tag description for the “QR image” needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
  • Move the following properties to the body element and change the height: 100vh; to min-height: 100vh;:
main {
    display: flex;
    justify-content: center;
    align-items: center;
    height: 100vh;
}

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding!🎄🎁

0

Blerim 270

@approved4me

Posted

@vcarames Hi, why it is relevant to change the height to min-height? Thanks

0

@VCarames

Posted

@approved4me

It is ideal for a responsive design.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord