Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

mihkelal 10

@mihkelal

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

geomydas 1,060

@geomydas

Posted

only thing I would change is the div tag that has the class of .card into a <main> tag.

Marked as helpful

1

@fortuneiyoha

Posted

Congratulations on completing the challenge! 🎉

Improve Accessibility

To enhance accessibility, it's important to structure your page content using semantic landmarks and tags. One suggestion is to use the <main> tag to wrap your primary content. Here's an example:

<!-- index.html -- >
<main class="card">
  ...
</main>

Improve Styles

To ensure your content fits well on the page, it's a good idea to remove default margins. Using a CSS reset is a comprehensive solution, but for this case, removing the body margin and setting a minimum height will do the trick. Here's how you can update your CSS:

/* index.css */
body {
  ...
  min-height: 100vh;
  margin: 0;
  ...
}

Great job on your project! 😄 Keep up the excellent work and happy coding!

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord