Skip to content
Submitted about 2 years ago

QR code component

vid.szabi•20
@vid-szabi
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Nneoma Njoku•1,210
    @SatellitePeacePosted about 2 years ago

    Hello @vid-szabi, congratulations on completing this challenge

    • here are a few tips Your card is not properly centered, to do this you can use
    Body{
display:flex;
Flex-direction:column;
Justify-content:center;
align-items: center:
min-height:100vh
}
    • Also set your main container to
    main{
display:flex;
Flex-direction:column;
Justify-content:center;
align-items: center;
}

    NOTE: your main container is the container enclosing all your elements

    Also the sample text of your card is still present you are meant to delete the text after using it to build the card

    Marked as helpful
    1
    vid.szabi•20
    @vid-szabiPosted about 2 years ago

    @SatellitePeace Thanks a lot for your help :)

    1
  • Travolgi 🍕•31,400
    @denieldenPosted about 2 years ago

    Hello Vid, You have done a good work! 😁

    Some little tips to improve your code:

    • create a separate css stylesheet and not write the css inside the html
    • add main tag and wrap the card for improve the Accessibility
    • also you can use article tag instead of a simple div to the container card for improve the Accessibility
    • img element must have an alt attribute, it's very important!
    • remove all unnecessary code, the less you write the better as well as being clearer: for example the div container of image
    • instead of using px use relative units of measurement like rem -> read here

    Keep learning how to code with your amazing solutions to challenges.

    Hope this help 😉 and Happy coding!

    0
  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hi @vid-szabi, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

    1.Add the website favicon inserting the svg image inside the <head>. <link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">

    2.Add <main> instead of <div> to wrap the card container. This way you show that this is the main block of content and also replace the div with a semantic tag.

    3.Replace the <p> containing the main title with <h1> note that this title is the main heading for this page and every page needs one h1 to show which is the most important heading. Use the sequence h1 h2 h3 h4 h5 to show the hierarchy of your titles in the level of importance, never jump a level.

    4.Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

    5.Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

    6.Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

    Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

    ✌️ I hope this helps you and happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord