Skip to content
Submitted almost 2 years ago

qr-code-card-html-css-flexbox

avrojp•30
@avrojp
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

  • I found it difficult to figure out given instructions for desktop: 1440px & phone: 375px. This solution is already responsive. Why to work for 1440px & 375px?
  • I am sure of all lines of codes.
  • No question.

Community feedback

  • Hassia Issah•50,650
    @HassiaiPosted almost 2 years ago

    Replace <div class="row"> with the main tag and <h2> with <h1> tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

    Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on this watch this https://youtu.be/N5wpD9Ov_To

    Hope am helpful.

    Well done for completing this challenge. HAPPY CODING

    Marked as helpful
    1
    avrojp•30
    @avrojpPosted almost 2 years ago

    @Hassiai Thanks

    0
  • Kitketovsky•45
    @KitketovskyPosted almost 2 years ago

    In design folder you are given photos of desktop (1440px) and mobile (375px) versions of your future site. It's not necessary to use these values as breakpoints or something. Just what it should look like at certain point (in our case - resolution).

    Marked as helpful
    1
    avrojp•30
    @avrojpPosted almost 2 years ago

    @Kitketovsky Got it! Thanks

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord