Your overall solution looks goof! But I'd also like to markup some points, you may try to improve.
- Try building design on Figma file. It is vital for front-end developer to know basic usage of Figma.
- I believe you shouldn't make QR-code stretched vertically.. It'll be best to keep it as a square
- Try using of
padding
andmargin
properties instead of separatemargin-top
,margin-bottom
,margin-right
etc. - Avoid using too many
div
tags. In your code it wasn't necessary to add additonal wraps forimage
,next
andpara
. - [Non critical] Use more specific class names. For me, it was kinda tough to understand what
next
andpara
were, but it could happen because it is written in you language I don't understand :D
That's all issues I could find looking at your code and site. Good job! Love your solution!
Marked as helpful
0