QR Code Component

Community feedback

• 

  Maksym Perekhodko•50

  @kinqbertPosted 7 months ago

  Your overall solution looks goof! But I'd also like to markup some points, you may try to improve.

  1. Try building design on Figma file. It is vital for front-end developer to know basic usage of Figma.
  2. I believe you shouldn't make QR-code stretched vertically.. It'll be best to keep it as a square
  3. Try using of padding and margin properties instead of separate margin-top, margin-bottom, margin-right etc.
  4. Avoid using too many div tags. In your code it wasn't necessary to add additonal wraps for image, next and para.
  5. [Non critical] Use more specific class names. For me, it was kinda tough to understand what next and para were, but it could happen because it is written in you language I don't understand :D

  That's all issues I could find looking at your code and site. Good job! Love your solution!

  Marked as helpful

  0