Qr code component

Community feedback

• 

  Umer Khokhar•220

  @Umer-KhokharPosted over 1 year ago

  Hi @Luneaa,

  Your code looks like very good. I have some recommmendation for you to write better code,

  Tip 1: If you want to centered items both horizontally and vertically by flexbox you should set height to 100%

  Tip 2: On cards, always use max width property instead of width only or you can use % if possibe (not in this case) and avoid setting fixed height on cards this will create problems when you are working with the bigger projects to make them responsive

  Tip 3: On card (in this case) if you need to give img full width of as card use % like the

  img {

  width: 100%: (or what ever you want)

  }

  This will make your image resposive don't use px on img because when you reach the maximum width you set on img (in your case 288px) cause problems and you need to do some extra work

  I hope this will help you!

  Happy coding 😊

  Marked as helpful

  1
• 

  Islammadian1•80

  @Islammadian1Posted over 1 year ago

  congratulation, you should push README-template.md not README.md but after renaming "README-template.md" to "README.md" and there some things to edit in readme file you will put repo link , live site (demo) link , screenshot for your demo and your social links if you like .

  1