QR code component

Community feedback

• 

  Dylan Heslop•760

  @dylan-dot-cPosted 4 days ago

  Well done on completing your first challenge! You have a long way to go and you only get better.

  For Figma, the more you use it the better you get at inspecting the designs but if you hold the ctrl button(on windows) and move your cursor you can see the spacing between different elements and that would be good for padding and margin.

  Only issue with this is that you need to center it vertically, seeing that you used flex box and justify-content you also need align-items to center it vertically.

  Note if you use align items it will center the content to the height of the container... So you need to make sure the container is the same height as the screen/window so don't use 100% as that would be relative but rather 100vh as that would make it full height of the screen.

  Also another tip is to do what is in the Readme-template.md as it's important for when others want to look at your project and it gives you more details. Also make sure you put the link on the GitHub repo as well. All of these will make you look more professional and you are actually putting in the extra effort to become a programmer. Because at the end of the day, it's more that just coding but also documentation

  0

  ---

  

  Karthik2242•20

  @Karthik2242Posted 4 days ago

  @dylan-dot-c Thank you so much for your review and I will improve the necessary things to make it more understandable and thank you for sharing your thoughts it gives me an idea how should I need to do the project.

  0