qr-code-component

Community feedback

• 

  Hassia Issah•50,650

  @HassiaiPosted almost 2 years ago

  The <div class="attribution"> should be out of <div class="container">, replace<div class="container">with the main tag, <h2> with <h1> and <div class="attribution"> with the footer tag to fix the accessibility issues. for more on semantic html visit https://web.dev/learn/html/semantic-html/

  Use rem or em as unit for the padding, margin, width and preferably rem for the font-size for more on CSS units watch this https://youtu.be/N5wpD9Ov_To

  Hope am helpful.

  Well done for completing this challenge. HAPPY CODING

  Marked as helpful

  0

  ---

  

  K.Damsith•330

  @DamsithcoderPosted over 1 year ago

  @Hassiai Thank you for your comment.

  0