Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Component

@nachospreafico

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I found really difficult to align the card to the center of the body for the desktop version, so the way I managed it is what I am most unsure of. Is it good practice to add display: grid to the body? Thanks in advance!

Community feedback

@khushi0909

Posted

  1. its ok to add grid but i think you need more learning and practice for grid and i think you must have used grid template-column 1fr 1fr 1fr or there are other ways also to do .read

https://css-tricks.com/snippets/css/complete-guide-grid/

2)you can also use flexbox for centering or transform:translate() etc

3)i cannot see any responsiveness implemented ,it will be great if you do that with for ex media queries etc

4)Read about h1 tag its the most important and every website should have atleast one https://www.semrush.com/blog/h1-tag/

5)you should learn about semantics HTML and using it for ex footer ,main etc

All the best

Marked as helpful

0

@feliceNicolasBarcellona

Posted

try this

@media only screen and (max-width: 1440px) body { background-color: #d5e1ef; display: flex; justify-content: center; align-items: center; flex-direction: column; height: 98vh; /* padding-top: 4%; / / padding-bottom: 2%; */ }

Marked as helpful

0
Aq1q 220

@Aq1q

Posted

It looks like display grid doesn't change how your body behaves, it does not center your component

You could give it height of 100vh to take whole page, display it as flex, make it's direction column so that your footer stays at the bottom and justify it's content to the center, so your code would look something like this:

body {
    display: flex;
    flex-direction: column;
    justify-content: center;
    align-items: center;
    height: 100vh;
}

This also makes paddings in your body, and both margins in your .card-container obsolete, because you already have it centered within body tag

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord