QR Code Component

Community feedback

• 

  Anosha Ahmed•9,300

  @anoshaahmedPosted almost 3 years ago

  hey good job on this challenge! your report above shows a few issues though:

  • wrap everything in your body in <main> OR use semantic tags! if you're using div right after body, then give them a role=""; however, it's a little frowned upon to use role right after body, so try to stick with semantic tags instead. you can read more about landmarks here
  • you should have at least one <h1> in your webpage

  here is a list i made of accessibility issues & best practices

  hope this helps :))

  Marked as helpful

  0
• 

  Naveen Gumaste•10,480

  @NaveenGumastePosted almost 3 years ago

  Hay ! Good Job you made it look nearly perfect to the preview

  These below mentioned tricks will help you remove any Accessibility Issues

  -> Add Main tag after body like it should be your container

  -> For 1st heading or h1 tag, use header tag and then inside the header put your h1 or h2 etc

  -> But use header tag only once in main heading element.

  -> Please use a style.css file so everything will be neat

  That;s all Keep up the good work!

  Marked as helpful

  0
• 

  Rio Cantre•9,690

  @RioCantrePosted almost 3 years ago

  Hello there! Great job with this one. Viewing your solution, you did well coding the design. I would suggest the following for you.

  • Instead of using style , create another file for CSS and import all the style properties and link the directory inside the head tag
  • Wrap the qr-container with specific tag like main to make it semantic

  Overall you did very well and Keep up the good work! Cheers!

  Marked as helpful

  0

  ---

  

  Abdulkader A Abdi•310

  @aaabdulakaderPosted almost 3 years ago

  @RioCantre Thanks

  1