Submitted almost 2 years ago
QRCode-FrontEndMentor Free Development Exercise
@AdejohOS
Design comparison
SolutionDesign
Solution retrospective
The project was a good one as i was able to center my content in my container, add padding and margin to the title(h2) element.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Congrats on completing your first challenge!🎊🍻
Here are some suggestions to help improve your code:
- Do not use percentages ❌ for your component's container as it cause it to grow/shrink indefinitely, which will cause your component to warp.
- The
alt tag
description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
- Move all of these properties to the
body
and change theheight
to min-height`;
.container { display: flex; align-items: center; justify-content: center; background-color: #d5e1ef; height: 100vh; }
- A
media query
is not needed ❌ for this challenge. Using responsive properties will do in making your content responsive.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord