Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Request path contains unescaped characters
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code component

Aish 60

@wajasha02

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

I finally completed my first challenge, I want to continue making interesting projects to improve my skills.

What challenges did you encounter, and how did you overcome them?

I found it difficult to center a div and found a guide on w3school to overcome this problem.

What specific areas of your project would you like help with?

nothing for now. But I want my designs to be responsive, I've found it difficult to do so

Community feedback

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

BODY MEASUREMENTS 📐:

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens, such as mobile devices in landscape orientation
  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.
  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

0

Account Deleted

Great site good job! For center things I found that margin: 0 auto is great if of course width of the element is not taking all available space that is left.that is why we can use width on element to change that kind of default behavior of block-level elements. General 99% things are naturally responsive and you can check if you write only html try to put it on phone and you will see how text is nicely wraping around but images are not doing that that is why i said 99% its important to understand default behavior and box model because that can lead to building nice responsive site.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord