romila• 3,570
@romila2003
Posted
Hi @mihir2226,
Welcome to frontendmentor.io and congratulations 🎉 on completing your first challenge. It was a great attempt but there are some minor issues I want to address:
- It is semantically correct to wrap your code within the
main
tag e.g.<main class="container"></main>
. - It is also semantically correct to wrap your footer within the
footer
tag e.g.<footer class="attribution"></footer>
.
It is important that the semantics are correct as this relates to accessibility which essentially helps blind users with using screen readers.
Overall, great attempt and keep coding 👍.
1