QR Code Component

Community feedback

• 

  Snehamoy Bag•600

  @snehamoybagPosted over 2 years ago

  Hi @hWeitian, Congratulations on completing on your first project 👏 I really liked how you used Flex-box efficiently to match the desired outcome. Great job!

  One concern i can notice in your css is the html { width: 100vw; height: 100vh } 😅 as i've learnt earlier from a fellow frontend mentor dev that setting a fixed width and height can give scroll bars to some device and worse.. the content might even get cropped. So i'd recommend you to never use width to set the pages cause width is by default 100% on all devices and is responsive. On the other hand setting a fixed height can cause the content to overflow or get cropped.. so whenever you need to set a height.. always use the min-height property 😄👍

  Marked as helpful

  0

  ---

  

  hWeitian•20

  @hWeitianPosted over 2 years ago

  Hi @snehamoybag, thank you so much for your feedback. I will keep that in mind for future projects 😄

  1