Skip to content
Submitted almost 2 years ago

QR code component

Yevhenii Kozhevin•40
@DexLuthor
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Im not quire sure if i used rem correctly, thus not sure if responsiveness is properly in place :\

Community feedback

  • Ryan Hemrick•290
    @Ryan-HemrickPosted almost 2 years ago

    Hey!

    With respect to your question above: Since rem units are relative to the font-size on the :root element, when you define a font-size: 10px on the :root, it updates your page to where 1rem is equal to 10px instead of the default 16px.

    Unless you are dynamically changing the :root element's font-size with media queries, the font-sizes of your elements and the padding you have set with rem units will not change on resize. (if I am interpreting your question properly!)

    One quick recommendation would be to add a style such as body { margin: 0; } because the default user agent stylesheet (for Chrome) is adding an 8px margin to the <body> that is causing both horizontal and vertical scrollbars to appear!

    I hope this was helpful. I still need to get better at using markdown...

    Marked as helpful
    0
    Yevhenii Kozhevin•40
    @DexLuthorPosted almost 2 years ago

    @Ryan-Hemrick Thank you very much, man. That was helpful. Hope you'll learn markdown, and good luck with asciidoc in future xDDD (joking :D)

    1
    Ryan Hemrick•290
    @Ryan-HemrickPosted almost 2 years ago

    @DexLuthor I look at a lot of these comments and it feels like another version of CSS xD

    0
  • Melvin Aguilar 🧑🏻‍💻•61,140
    @MelvinAguilarPosted almost 2 years ago

    Hi there 👋. Good job on completing the challenge ! I have some feedback for you if you want to improve your code.

    HTML:

    • The alt attribute should explain the purpose of the image. Uppon scanning the QR code, the user will be redirected to the frontendmentor.io website, so a better alt attribute would be QR code to frontendmentor.io

    If you want to learn more about the alt attribute, you can read this article.

    • You should not use inline-CSS because it is not a good practice. Instead, you should use an external stylesheet to style your page. By doing this, you will be able to have a better organization of your code and will be able to understand it better.

    CSS:

    • Currently, the viewport unit variants are compatible with 68.82% of desktop browsers. However, it is important to note that some older browsers may not support these units. It is important to test your website on multiple devices and browsers to ensure compatibility. On my computer your solution is not centered fix
    • You should use a CSS reset to remove the default browser styles and make your page look the same in all browsers.

    Popular CSS resets:

    I hope you find it useful! 😄 Above all, the solution you submitted is great!

    Happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord