QR code component

Community feedback

• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi Bitu,

  Welcome to the frontend mentor community and congratulations for 🎉 for completing your first challenge, the card looks great, and it is great that you used the flex property to center the card. There are some issues/suggestions I want to address:

  1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. To prevent the card from touching the side of the screen, particularly in mobile screen, you can give your body, a margin property with a value of 0 10px

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  0

  ---

  

  Bitu rauth•40

  @rauthbituPosted about 2 years ago

  @romila2003 Thanks you so much .. I will surely implement your suggestions.

  1