Skip to content
Submitted about 1 year ago

QR code component

Marek_Ćwioro•50
@marek4882
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I would ask for feedback. It will be a great help for improve my skills.

Community feedback

  • Blake Lyons•300
    @blakelyonsPosted about 1 year ago

    Overall you did a great job of getting it close to the design. The only things I noticed are:

    • The card is missing the box-shadow that is in the design.
    • I would avoid using super generic class names for the text on the card. For example, .text-1 really could be something like .card-title and .text-2 could be something like .card-text. This makes it easier to read the code and understand the purpose of the text. This helps if you're working on a team with multiple developers working on the same project.
    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord