Skip to content
Submitted about 2 years ago

QR Code Component

Loris DUCAMPS•425
@LorisDucamps
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Loris, Congratulations on completing this challenge!

    I saw your solution preview site and I think it's already really good. Here’s some tips for you to improve it:

    1.Your html code is not optimized yet, since its too long and have some unnecessary elements. To make it clean you start by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    2.I saw that for some properties you’ve used rem and for others px. In this case it is better to use only one kind of unit to have a better organization for your code. relative units as rem or em that have a better fit if you want your site more accessible between different screen sizes and devices. REM and EM does not just apply to font size, but to all sizes as well.

    3.Save your time using a CSS RESET to remove all default settings that are annoying as the margins, paddings, decorations and optimize it making easier to work,see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/

    ✌️ I hope this helps you and happy coding!

    1
    Loris DUCAMPS•425
    @LorisDucampsPosted about 2 years ago

    Hi @correlucas !

    Thank you for all of your recommendations.

    1. Indeed I tend to include my elements in several divs for no reason. It's my paranoid side :) Thank you

    2. I actually didn't take the time to review the CSS. I will fix it! Thanks

    3. Regarding the CSS reset, in the case of a small project like this I avoid importing a huge block of CSS code. Thanks again for the article.

    Happy coding!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord