Skip to content
Submitted about 2 years ago

QR Code Component

Kingsley Arinzechukwu•40
@ArthurKingDev
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

Hi everyone! I'm not sure if I targeted the layouts right. Kindly take a look at my code and give me feedback. Thanks.

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted about 2 years ago

    👾Hello Kingsley , congratulations for your first solution!👋 Welcome to the Frontend Mentor Coding Community!

    Great start and great first solution! You’ve done really good work here putting everything together, I’ve some suggestions you can consider applying to your code: Something I've noticed in your code is that in many occasions you've added some <div> to wrap contents that don't really need to be inside of a div block. Note that for this challenge all you need is a single block to hold all the content, can be <div> or <main> if you want to use a semantic tag to wrap the content, the cleanest structure for this challenge is made by a block of content with div/main and all the content inside of it (img, h1 and p) without need of any other div or something. See the structure below:

    <body>
<main>
<img src="./images/image-qr-code.png" alt="Qr Code Image" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

    ✌️ I hope this helps you and happy coding!

    Marked as helpful
    0
    Kingsley Arinzechukwu•40
    @ArthurKingDevPosted about 2 years ago

    @correlucas thanks so much!

    1
  • Travolgi 🍕•31,400
    @denieldenPosted about 2 years ago

    Hi Kingsley, congratulations on completing the challenge, great job! 😁

    Some little tips for optimizing your code:

    • use article tag instead of main tag to the container card for improve the Accessibility. Main tag is for wrap the all main page content
    • remove all margin from card class
    • use flexbox to the body to center the card. Read here -> best flex guide
    • after, add min-height: 100vh to body because Flexbox aligns child items to the size of the parent container
    • instead of using px use relative units of measurement like rem -> read here

    Hope this help! Happy coding 😉

    Marked as helpful
    0
    Kingsley Arinzechukwu•40
    @ArthurKingDevPosted about 2 years ago

    @denielden your feedback is a great tool! Thanks.

    1
    Travolgi 🍕•31,400
    @denieldenPosted about 2 years ago

    @ArthurKingDev you are welcome and keep it up :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord