QR code using HTML and CSS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted almost 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  • Best practice ✅, before moving on to the next challenge, always check your FEM report, to see what is incorrect and update your code with it so that you would not make the same mistake over again. This something that should be done right after submitting your challenge.

  • The alt tag description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

  • To properly center ✅ your content to your page, you will want to add the following to your body (this method uses CSS Grid):

  body {
      min-height: 100vh;
      display: grid;
      place-content: center;
  }
  

  More Info: 📚

  Centering in CSS

  • Change width to max-width in your component’s container to make it responsive. You will also want to remove the height as it is unnecessary.

  • A media query is not needed ❌ for this challenge. Using responsive properties will do in making your content responsive.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🎆🎊🪅

  Marked as helpful

  0