QR code component

👾Hi @Cr0zy07, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!

Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

The main heading has the tag <h2>, in this case, you should replace it with <h1> since this heading is the main title on this page. Remember that every page should have one <h1> to declare which is the most important title and that you should follow the hierarchy using the heading sequence (h1, h2, h3, h4, h5) and never jump a level.

Clean your code by removing some unnecessary divs, most of the content can stand alone without a div. Use div only for blocks that need a special alignment or the content needs a special positioning.

Add a margin of around margin: 20px to avoid the card touching the screen edges while it scales down.

Use relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices. These units are better to make your website more accessible. REM does not just apply to font size, but to all sizes as well.

Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

✌️ I hope this helps you and happy coding!

Hey @Cr0zy07, some suggestions to improve you code:

• The Alt Tag description for the QR image needs to be improved upon. Its needs to tell screen reader users what it is and where it will take them to when they scan it.

• Your "Improve your front-end skill by building projects" needs to wrapped in an <h1> Heading. If this in a larger site with more cards, then the <h2> or <h3> Heading might be the better option.

• Delete the height: 500px; from your .card. Your content will create the height on its own.

• Change the width to max-width in the .card to make it fully responsive.

• Change the width: calc(320px - 2rem); to max-width: 100%; to make it fully responsive.

• Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.

This is not enough:

* {
    margin: 0;
    padding: 0;
    box-sizing: border-box;
}

Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.

https://www.joshwcomeau.com/css/custom-css-reset/

https://meyerweb.com/eric/tools/css/reset/

http://html5doctor.com/html-5-reset-stylesheet/

Happy Coding!