@Sujood-Qureshi
Posted
Hey Emanuel 🙋♂️ ….
Good job on completing the Qr code component challenge
I have some suggestions for you about your code.
index.html
-
Use <main> tag to wrap the page's main content instead of <div> tag. It will show the search engines that the particular content is essential on that page. You can read more about <main> tag here.
-
Try to define more understandable alt text inside <image> tag. It shows that your website is user-friendly. You can read more about alt text here.
-
Use the <footer> tag to wrap all the information about the author of the website instead of the <div class=” attribution”> tag. The <footer> tag defines a footer for a document or section. An <footer> element typically contains authorship information. copyright information. You can read more about <footer> tag here.
style.css
-
Try to use Flex properties or Grid properties to make your layout clean. These layout features of CSS3 will help you to make your page layout almost responsive. It will be easier to code in CSS3 using flex or grid properties as compared to using margin and padding for every single element.
-
You should read the style-guide.md file to understand what design your challenge needs
I hope you find it useful! May your front-end journey be filled with successful 😊😊
