Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Your session has expired please log in again.
Your session has expired please log in again.
Your session has expired please log in again.

Submitted

QR Code Component

@polzak

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

@VCarames

Posted

Hey there! 👋 Congrats on completing your first challenge!🎊🍻

Here are some suggestions to help improve your code:

  • FEM Best practice ✅, before moving on to the next challenge, always check your FEM report, to see what is incorrect and update your code with it so that you would not make the same mistake over again. This should be the first thing that should be done ⚠️ right after submitting the challenge.
  • Every site should always have ✅ a main element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.

More Info: 📚

MDN Main Element

  • Avoid skipping heading levels ⚠️. Always start with the h1 (which can only be used once) and you will go down the hierarchy level depending on the heading’s importance.
  • The alt tag description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
  • Move all of these properties to the body and change ⚠️ the height to min-height in your body element, to improve your component's responsiveness. You will also delete the width as it is unnecessary.
.container {
  width: 100%;
  height: 100vh;
  background-color: hsl(212deg, 45%, 89%);
  display: flex;
  flex-direction: column;
  align-items: center;
  justify-content: center;
}
  • Change ⚠️ width to max-width in your component’s container to make it responsive.

If you have any questions or need further clarification, feel free to reach out to me.

Happy Coding! 🎆🎊🪅

Marked as helpful

1

@polzak

Posted

@vcarames

Thank you very much for your valuable advice and detailed suggestions.

I improved my solution based on them and find it much better. I really appreciate your advice on a main element, heading levels, accessibility, responsiveness, and using a body element.

I learned a lot from doing this challenge and a lot again from your advice. Happy Coding!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord