@VCarames
Posted
Hey there! 👋 Congrats on completing your first challenge!🎊🍻
Here are some suggestions to help improve your code:
- FEM Best practice ✅, before moving on to the next challenge, always check your FEM report, to see what is incorrect and update your code with it so that you would not make the same mistake over again. This should be the first thing that should be done ⚠️ right after submitting the challenge.
- Every site should always have ✅ a
main
element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, it will serves as the component’s container ⚠️.
More Info: 📚
- Avoid skipping heading levels ⚠️. Always start with the
h1
(which can only be used once) and you will go down the hierarchy level depending on the heading’s importance.
- The
alt tag
description for the “QR image” needs to be improved upon ⚠️. Its needs to tell screen reader users what it is and where it will take them to when they scan it.
- Move all of these properties to the
body
and change ⚠️ theheight
tomin-height
in yourbody
element, to improve your component's responsiveness. You will also delete thewidth
as it is unnecessary.
.container {
width: 100%;
height: 100vh;
background-color: hsl(212deg, 45%, 89%);
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
}
- Change ⚠️
width
tomax-width
in your component’s container to make it responsive.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🎆🎊🪅
Marked as helpful
@polzak
Posted
@vcarames
Thank you very much for your valuable advice and detailed suggestions.
I improved my solution based on them and find it much better. I really appreciate your advice on a main element, heading levels, accessibility, responsiveness, and using a body element.
I learned a lot from doing this challenge and a lot again from your advice. Happy Coding!