@correlucas
Posted
👾Hi @zp021, congratulations on your solution!👋 Welcome to the Frontend Mentor Coding Community!
Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:
Your solution is great and the code is working, but the HTML structure can be reduced by removing unnecessary divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading, and paragraph.
Here’s one example to show can be cleaner this HTML structure:
<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
<h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>
To reduce the CSS you can use the direct selector for each element instead of using class this way you have a code even cleaner, for example, you can select everything using the direct selector for (img, h1, and p, main).
Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR
✌️ I hope this helps you and happy coding!
@zp021
Posted
@correlucas That makes sense, I get that we should generally strive for less code and cleaner solutions, so that was very helpful. I'll have to take a closer look at your solution. I'm still learning JavaScript, so my skillset is limited but as I gain more experience, it would be fun to revisit each challenge, improve, embellish, and put a personal touch to each as you have done. Thanks!
@correlucas
Posted
@zp021 This is amazing, then tell me if worked and if was useful for you! Keep posting amazing content =)
