QR CODE COMPONENT

Community feedback

• 

  Scott Ning•170

  @ning-sy210Posted 12 months ago

  Hey there, great job on completing this challenge! I see that you managed to match the design very closely, so bonus points for that! If you add padding: 0 8px; to your <p> element, you can match the design even closer! :)

  I've taken a look at the CSS that you have written, and I'm not too sure what the max-height: 33rem; is for on your <section> element. I think it's safe to simply remove that line, because the best code is the code you don't have to write 😏

  Other than that, great job for using semantic HTML tags! The <main>, <section> and <h1> tags are not very commonly seen in most of these beginner attempts, so here's an extra cookie for you! 🍪

  1

  ---

  

  Thu Nguyen•240

  @NgocMinhThuNguyenPosted 12 months ago

  Hello there,

  I've just updated my code. Thank you for your feedback 🌻

  0
• 

  P

  Øystein Håberg•10,390

  @Islandstone89Posted 12 months ago

  Hi there, this looks pretty good. A few things to take note of:

  HTML:

  • Alt text also needs to say where it leads(frontendmentor.io).

  • Footer text needs to be wrapped in a <p>.

  CSS:

  • It's good practice to include a CSS Reset at the top.

  • You can remove font-size: 1rem - this is the default value.

  All in all - good job :)

  0