Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code Component

@Yosef-S-A

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


In your opinion, does my solution follow best practices?

Community feedback

@alejox

Posted

The project looks very good, if you want to have a plus, you can apply the BEM methodology, so that you improve the use of HTML classes, on the other hand, you can review how to use and set the rem fonts, look for the 62.5% method, and if If you want to go further, you can use sass, I still recommend BEM first, so that when you go to sass, it will be much easier

Marked as helpful

2

rishi 60

@rishi-jsdev

Posted

@alejox

Thanks for the feedback, Luis! 🙏 I will surely look into BEM and rem fonts.

0

@0xabdulkhaliq

Posted

Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

QR iMAGE ALT TEXT 📸:

  • The QR Code Component involves scanning the QR code, the image is not a decoration, so it must have an alt attribute which should explain the purpose of the image.
  • The alt with qr code is not even explaining for what the QR image need to be used.
  • So update the alt with meaningful text which explains like QR code to frontendmentor.io

Example

<img src="/images/image-qr-code.png" alt="QR code to frontendmentor.io">

.

I hope you find this helpful 😄 Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1

@Yosef-S-A

Posted

Thanks @0xAbdulKhalid. I will do that.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord