Qr code componenet using CSS Flexbox

Community feedback

• 

  romila•3,570

  @romila2003Posted about 2 years ago

  Hi @Grimjow-immortal,

  Welcome to the frontend mentor community and congratulations for 🎉 for completing your first challenge, the card looks great. I found some issues I want to address:

  1. It is best practice to wrap the main content within the main tag which would ensure that your content is wrapped within the correct landmarks e.g. <main class="container"></main>
  2. You should also wrap the footer within the footer tag e.g. <footer class="attribution"></footer>
  3. Your img tag is missing the alt attribute which is important images contain this attribute
  4. Instead of using the p tag for the title, I would recommend you to use the h1 tag and keep the p tag for the description
  5. The font-family property is missing for the texts and can be found within the style-guide
  6. Instead of using the margin property, you can use the flex property to center the card e.g.

  body {
    display: flex;
    align-items: center;
    justify-content: center;
    min-height: 100vh;
    flex-direction: column;
  }
  

  Overall, great attempt and wish you the best for your future projects so keep coding 👍.

  Marked as helpful

  0

  ---

  

  Grimjow-immortal•20

  @Grimjow-immortalPosted about 2 years ago

  @romila2003 thank you bro

  1