@DylandeBruijn
Posted
Hi @IvanoCro,
Congratulations on your solution, it looks very close to the design specifications. Your code is clean and easy to read.
A couple of friendly suggestions:
-
Instead of using a
div
for your card you could usearticle
to make it more semantic. -
I suggest using
min-height: 100vh
instead ofheight: 100vh
on yourbody
. So you don't run into overflow issues if the card gets bigger. It's not a big problem in this example, just a good practice. -
I suggest keeping the height of the card as
auto
and not setting apx
value. If you add more text to the description you run into overflow issues. -
You could try to use CSS variables to make your style guide values more reusable.
I hope you find my feedback helpful and I'll be happy to answer any other questions you have.
Marked as helpful
@IvanoCro
Posted
Hi @DylandeBruijn Thank you for the feedback, it helps me a lot.