Submitted almost 2 years ago

QR Code Compoment Design

Isfaqul• 330

@Isfaqul

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Community feedback

Travolgi 🍕• 31,420

@denielden

Posted almost 2 years ago

Hello Isfaqul, You have done a good work! 😁

Some little tips to improve your code:

use main tag to wrap the card and improve the Accessibility but not as a container of that one element
also you can use article tag instead of a simple div to the container card for improve the Accessibility
remove all unnecessary code, the less you write the better as well as being clearer: for example the picture container of image
you can use picture tag when you need to change the image by resolution -> read here
use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
instead of using px use relative units of measurement like rem -> read here

Keep learning how to code with your amazing solutions to challenges.

Hope this help 😉 and Happy coding!

Marked as helpful

Lucas 👾• 104,440

@correlucas

Posted almost 2 years ago

👾Hi @Isfaqul, congratulations on your solution!

Great solution and a great start! From what I saw you’re on the right track. I’ve few suggestions for you that you can consider adding to your code:

Reduce your code by removing unnecessary elements. The HTML structure is working but you can reduce at least 20% of your code by cleaning the unnecessary elements, you start cleaning it by removing some unnecessary <div>. For this solution you wrap everything inside a single block of content using <div> or <main> (better option for accessibility) and put inside the whole content <img> / <h1> and <p>.

<body>
<main>
<img src="./images/image-qr-code.png" alt="QR Code Frontend Mentor" >
 <h1>Improve your front-end skills by building projects</h1>
<p>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</p>
</main>
</body>

Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/qr-code-component-vanilla-cs-js-darklight-mode-nS2aOYYsJR

✌️ I hope this helps you and happy coding!

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord