QR Code Compoent

Community feedback

• 

  Shah Faisal•170

  @Shah-Faisal-cloudPosted 2 months ago

  Great job on completing the project! The code looks solid, and it’s clear you put in a lot of effort.

  Just a small suggestion regarding the styling for card__img. You’ve defined both overflow: hidden and border-radius on the div, and then you’ve also added a border-radius to the img inside it. The overflow: hidden on the parent already makes the image respect the rounded corners, so the border-radius on the img might not be needed. It’s a tiny thing, but simplifying this can make the code a bit cleaner and easier to maintain.

  I hope this small change would be helpful for you moving forward.

  Marked as helpful

  1

  ---

  

  Pai-Kai Lee•250

  @PaiKai-LeePosted 2 months ago

  @Shah-Faisal-cloud thank you for feedback.
  Because I am confused about writing css for img tag, or use a parent div to wrap img then writing css for the parent div. so I do both. I will adjust the solution thanks!!

  0
• 

  osman-beni•40

  @osman-beniPosted 2 months ago

  Please pay attention to your spacing

  1