Skip to content
Submitted over 2 years ago

QR Code Compenent using HTML CSS and Flexbox

Marta Jo Telkamp•80
@idlehands1969
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I found this challenge fairly simple once I finally wrapped my head around flexbox (thanks to @themegazord here on frontendmentor.io and YouTuber Kevin Powell's Flexbox videos). After that it was just a matter of styling the text and sizing the image.

Any constructive criticism is always welcome. I am always learning.

Community feedback

  • Lucas 👾•104,340
    @correlucasPosted over 2 years ago

    👾Hello again Marta, congratulations for your new solution!

    Your card is already really good, I've only some suggestions regardin the html code and the border-radius.

    The border-radius has a strange aspect because you've used percentage, to have a perfect rounded border use instead px or rem. Try to replace in the container border-radius: 14px to see the difference.

    About the html you can reduce a lot of the code removing unnecessary divs, all you need is a single <main> or <div> to keep all the content inside, and nothing more. The ideal structure is the div and only the image, heading and paragraph.

    See the structure below:

    <body>
<main>
<img>
<h1></h1>
<p></p>
</main>
</body>

    👾My rating for this solution: ⭐⭐⭐⭐⭐

    👋 I hope this helps you and happy coding!

    Marked as helpful
    0
    Marta Jo Telkamp•80
    @idlehands1969Posted over 2 years ago

    @correlucas Thank you so much for the wonderful advice and the rating! Cheers!

    1
  • Harm Intemann•590
    @ghintemaPosted over 2 years ago

    Hi Marta,

    just reviewed your code and all I found is that there is a slight issue with the indentation :) Lines 20 to 30 need one more tab indentation. Right now, the div#box begins in the same column like the parent body. All the rest look neat and tidy to me! :)

    Hope to have helped you, keep going and happy coding! :)

    0
    Marta Jo Telkamp•80
    @idlehands1969Posted over 2 years ago

    @ghintema Thank you!

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord