Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code challenge

P
cjdemille 480

@cjdemille

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Gabriel_BC 300

@GabrielBC2021

Posted

Hello :D, just a couple of thing:

1.- You have your style.css but in your HTML you are including styles in the head tag, just cut those styles that you are using in your HTML and paste them in your style.css.

2.- I've seen in your repository that you took out some on the images that the project gives you, you can put them in the images folder, by doing this you are more organized and if someone watches your repository will understand everything you are doing in a better way.

3.- In your QR-code image and your container you are using so much the border-radius, you can try just using 1em instead of 2em, you can see the design and you will understand what i'm saying haha.

4.- You have in the project the file style-guide where tells you which properties, colors, font families, font size, etc, you are going to use, you can check it out and try while you are coding, take a look at the design so you have a better perspective of what you are doing in real time.

Hope these tips help you.

Little details that you make your website look better :D

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord