Atif Iqbal• 3,200
@atif-dev
Posted
Hi Falco, congrats🎉 on completing the challenge. Better take care about following points.
- Always check Frontendmentor Report Generator issues after submitting the project for removing errors and warnings. Use
alt(alternate text) attribute as it is mentioned in your Accessibility Report.altattribute is used for Screen readers technology. Whyaltattribute matters? Read here. To avoid accessibility issue "All page content should be contained by landmarks" use code as :
<body>
<main>
---your code here----
</main>
<footer>
</footer>
</body>
(why main matters? Read here)
- For proper centering the container(whole card) vertically and horizontally you can use code as:
body {
min-height: 100vh;
display: grid;
place-content: center;
}
Or you can learn centering from here.
- When we open GitHub repository link, at right side you will find an About Section. There, also include live preview link of your project. It is better for someone to check your live project while interacting with code.
- Include a README file in your GitHub project's solution and write about your working flow, findings, new learned things, useful resources, etc.
Hope you will find this Feedback Helpful.
Marked as helpful
1
Falco Böhnke• 10
@Falco-Boehnke
Posted
@atif-dev Hey, thanks for the feedback! Lots more to learn.
I have one thought I was wondering: If we have to set height, wouldn't dvh be the better unit, because it takes into consideration horizontal scrollsbars and mobile spacings? I am not sure how well supported it is, just read a bit about it
1
Atif Iqbal• 3,200
@atif-dev
Posted
@Falco-Boehnke there are some units that are intended to be better if considering responsiveness. Check out this video. Learn responsiveness, you will find out where to use which unit.
1
