Skip to content
Submitted 4 months ago

QR code challenge with HTML CSS basics and flexbox

Rachel Zhang•20
@Rach1975
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?
  • It's good to be out of tutorial hell.
  • I'd be more careful with the measurements of design. Try to recreate a closer looking version. Also do better at responsive design.
What challenges did you encounter, and how did you overcome them?
  • Had difficulties centering object and checking the space each component takes.
  • MDN documents and browser dev tools helped me out.
  • Not familiar enough with Github yet.
What specific areas of your project would you like help with?
  • How can I do better at getting the measurements as close to the original design?

Community feedback

  • Boris•2,850
    @mkborisPosted 4 months ago

    Hi @Rach1975 great job completing your first challenge, here are some suggestions to improve your work

    • Remove the height completely from the .frame-card also change the width to max-width: 385px;. Avoid setting fixed heights and widths on elements as this will cause lots of issues with the responsiveness of your layout, the element's content and using padding should determine it's size. Use max-width or min-height if you absolutely have to and the units should be relative units like rem.
    • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
    • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.

    Hope this helps

    Marked as helpful
    2
    Atatra•170
    @AtatraPosted 4 months ago

    @mkboris I had no idea about the rem/px thing, thanks!

    1
    Rachel Zhang•20
    @Rach1975Posted 4 months ago

    @mkboris Thanks for your help!

    1
  • Surjo-Sen-BD•110
    @Surjo-Sen-BDPosted 4 months ago

    You Need to do better next time

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord