Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code challenge with HTML CSS basics and flexbox

@Rach1975

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What are you most proud of, and what would you do differently next time?

  • It's good to be out of tutorial hell.
  • I'd be more careful with the measurements of design. Try to recreate a closer looking version. Also do better at responsive design.

What challenges did you encounter, and how did you overcome them?

  • Had difficulties centering object and checking the space each component takes.
  • MDN documents and browser dev tools helped me out.
  • Not familiar enough with Github yet.

What specific areas of your project would you like help with?

  • How can I do better at getting the measurements as close to the original design?

Community feedback

Boris 2,870

@mkboris

Posted

Hi @Rach1975 great job completing your first challenge, here are some suggestions to improve your work

  • Remove the height completely from the .frame-card also change the width to max-width: 385px;. Avoid setting fixed heights and widths on elements as this will cause lots of issues with the responsiveness of your layout, the element's content and using padding should determine it's size. Use max-width or min-height if you absolutely have to and the units should be relative units like rem.
  • Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
  • Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.

Hope this helps

Marked as helpful

2

Atatra 170

@Atatra

Posted

@mkboris I had no idea about the rem/px thing, thanks!

1

@Rach1975

Posted

@mkboris Thanks for your help!

1

@Surjo-Sen-BD

Posted

You Need to do better next time

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord