Boris• 2,870
@mkboris
Posted
Hi @Rach1975 great job completing your first challenge, here are some suggestions to improve your work
- Remove the
height
completely from the .frame-card also change thewidth
tomax-width: 385px;
. Avoid setting fixed heights and widths on elements as this will cause lots of issues with the responsiveness of your layout, the element's content and using padding should determine it's size. Usemax-width
ormin-height
if you absolutely have to and the units should be relative units likerem
. - Consider using a modern CSS reset at the start of the styles in every project. Like this one Modern CSS Reset.
- Font-size should be written in rem not px. This article explains it better Why font-size must NEVER be in pixels.
Hope this helps
Marked as helpful
2
Atatra• 170
@Atatra
Posted
@mkboris I had no idea about the rem/px thing, thanks!
1
Rachel Zhang• 20
@Rach1975
Posted
@mkboris Thanks for your help!
1