Submitted 2 days ago

QR Code challenge with HTML and CSS

mohamed-fathy3010• 10

@mohamed-fathy3010

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

This is the first time I use BEM. next time i will try to use other tools like SCSS or TS to train my self more with them.

What challenges did you encounter, and how did you overcome them?

No challenges encountered but i toke some time searching for some best practices and standards.

What specific areas of your project would you like help with?

Any feedback is appreciated.

Community feedback

Sergio Eduardo Castro Ceballos• 30

@SergioCasCeb

Posted 1 day ago

First of all, really well done with the use of the BEM methodology.

Only a few things that could help you improve it further:

You forgot to make the component fit all screen sizes. Even though the designs are made in the screen sizes of 375px and 1440px, you should always remember that screen sizes can go as small as 320px.
Add some padding to you main container so that the content are not touching the edges of the screen in small screen sizes

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord