Skip to content
Submitted 8 months ago

QR code challenge w/ flexbox

plantpirate•170
@plantpirate
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I'm proud I let myself finish the challenge and complete the steps. I get too concentrated on small parts of these projects and spend my time losing focus on the big picture.

What challenges did you encounter, and how did you overcome them?

The main challenges I encountered were small things like trying to get the right font size, padding, or margin. I seem to get caught up on those aspects during these projects. I tend to just reach a point where I call it good and tell myself I can come back to those later.

What specific areas of your project would you like help with?

I'm not really sure about specific areas. Theres so many ways to get the same outcome for a problem, it's just difficult seeing the simplest way to get the right result.

Community feedback

  • Øystein Håberg•10,710
    @Islandstone89Posted 8 months ago

    Good job. Here are some suggestions:

    HTML:

    • Move the CSS styles to the stylesheet.

    • Do not use words like "image" or "photo" in the alt text. Screen readers start announcing images with "image", so an alt text of "QR code image" would be read like this: "image, WR code image". The alt text must also say where it leads(frontendmentor.io).

    • The footer text must be wrapped in <p>.

    CSS:

    • Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

    • On the body, change height to min-height - this way, the content will not get cut off if it grows beneath the viewport.

    • max-width on the card should be in rem.

    • font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

    • Since all of the text should be centered, you only need to set text-align: center on the body, and remove it elsewhere. The children will inherit the value.

    • Paragraphs have a default value of font-weight: 400, so there is no need to declare it.

    • font-style: normal is the default, so there is no need to declare that explicitly.

    • On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container.

    Marked as helpful
    1
  • 2lana•160
    @2lanaPosted 8 months ago

    Hi, @plantpirate, perhaps the padding in lower indentation can be tried in %, then at the bottom there will be a different look

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord