QR Code Challenge using HTML and CSS Flexbox

Community feedback

• 

  Adriano•38,270

  @AdrianoEscarabotePosted almost 2 years ago

  Hi codecolastudio, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:

  Images must have alt text unless it is a decorative image, for any decorative image each IMG tag must have empty alt="" and add aria-hidden="true" attributes to make all the assistive technologies of the Web, as screen reader. Learn the differences between decorative/meaningless images vs important content.

  To improve the structure of the html document, prefer to wrap all the content with the main tag, since this challenge is just a component, it needs a main tag to know what the main content of the page is!

  To improve the accessibility of the project you could have put an h1. Every page must contain a level 1 header, for people who use screen readers, identity what the main title is and follow the sequence h1-h5

  <h1>Improve your front-end skills by building projects</h1>

  The rest is great!

  I hope it helps... 👍

  Marked as helpful

  1

  ---

  

  codecolastudio•100

  @cruz-jerwin15Posted almost 2 years ago

  @AdrianoEscarabote Thanks man, your review helps me a lot.

  1
• 

  Saulius K.•560

  @TH3RIVPosted almost 2 years ago

  Hi, @cruz-jerwin15!

  To answer your question on how to start being a Front-End developer, it all starts with educating yourself. I would suggest a course on "Udemy" made by Colt Steele or taking on the steps from "FreeCodeCamp" or both. That is what i am currently doing. Also helps to learn to do challenges here. I believe that you learn the most by doing it and making mistakes.

  Now onto your project and my suggestions:

  • Your page should contain landmarks, so it makes your code easier to read on what content is what and also helps screen-readers to figure out what is what. In this case your card should be wrapped withing main tags and your attribution should be wrapped within footer tags.
  • Try to avoid using px values as much as possible and use rem instead.
  • Try to start using "custom CSS properties". While this is not essential in this project, it is a good habit to develop.

  Hope this helps!

  Marked as helpful

  1

  ---

  

  codecolastudio•100

  @cruz-jerwin15Posted almost 2 years ago

  @TH3RIV Thanks for reviewing my solution to this challenge. I will use all of your suggestions. Thanks again.

  0